Setting up logger so tests can pass when run after JavaLoggerTest #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #135, there are other tests that fail when run after other tests in
JavaLoggerTest
. The reason for the failure is the same, and so this pull request proposes to introduce the same logic to explicitly set the logger toLog4JLogger
before the tests that need it to be set up.One thing to note is that these tests fail when run after tests in
JavaLoggerTest
, so another potential way to fix is to (re)set the logger in a teardown method forJavaLoggerTest
. In this style, it would be good ifLoggerFactory
provides a method to see what the active logger is so the test can set the active logger to that one.Please let me know if you want to discuss the changes more.