ui-core: add label stories #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turnerian2004
force-pushed
the
ian/add-label-stories
branch
2 times, most recently
from
274cc03
to
078cc44
Compare
turnerian2004
force-pushed
the
ian/add-label-stories
branch
from
078cc44
to
639fe81
Compare
clarani
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
LGTM and tested, thanks 🙏 ✅
From what I see, the hasHint props only removes the margin bottom of the label. If you want, you can indeed remove the story Hint (but we should keep the prop in the component since it is usefull, see the component Input for instance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 274
Comment:TheLabelcomponent has ahintprop. I do not see the value of this prop, since there is nostarlike in therequiredstory or additionaltextlike in the stories of the components that have ahintprop.Should the
hintprop be removed? Should theHintcomponent be passed to theLabelcomponent as an optional prop?