ui-core: nuke value in Select #538
Open
+5
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really need a value here, we can just use indexes instead. This makes it easier to use Select for small lists (e.g. 3 static choices) and simplifies the code. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/nuke-select-value
branch
from
60d499a
to
d071c0f
Compare
emersion
commented
Sep 24, 2024
| <option key={getOptionValue(option)} value={getOptionValue(option)}> | ||
| {getOptionLabel(option)} | ||
| </option> | ||
| /* eslint-disable-next-line react/jsx-key */ |
There was a problem hiding this comment.
We loose the key here, but since these lists are quite short I don't believe it matters.
There was a problem hiding this comment.
So we will have a warning in console each time we use the Select component ?
There was a problem hiding this comment.
That’s a generic component, We don’t know who is going to use it, and it could be a select of any size.
Besides, I think even with smaller lists react can get confused and mix up elements between renders if you don’t use keys.
kmer2016
reviewed
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need a value here, we can just use indexes instead. This makes it easier to use Select for small lists (e.g. 3 static choices) and simplifies the code.
Discussion: OpenRailAssociation/osrd#8838 (comment)