Fix clear input on blur when no match #695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achraf Mohyeddine <[email protected]>
|
Sounds like a good idea to me. |
RomainValls
approved these changes
Nov 21, 2024
emersion
reviewed
Nov 21, 2024
| @@ -198,8 +198,7 @@ const ComboBox = <T,>({ | |||
| } else if (!isInputInSuggestions && selectedOption) { | |||
| setInputValue(getSuggestionLabel(selectedOption)); | |||
| } else if (!isInputInSuggestions) { | |||
| setInputValue(''); | |||
| setSelectedOption(null); | |||
| clearInput(); | |||
There was a problem hiding this comment.
clearInput() will focusInput() at the end. This is confusing for users: they've navigated away from the input (either by clicking outside, or with Tab, or something else), but then focus is set back to the input.
|
The commit name has the "front: " prefix, but it should be "ui-core: ". Also it would be nice to mention that this is about the ComboBox component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.