-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: OSRD goes async #7103
WIP: OSRD goes async #7103
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7103 +/- ##
============================================
- Coverage 29.00% 27.97% -1.03%
Complexity 2250 2250
============================================
Files 1070 1069 -1
Lines 132704 135480 +2776
Branches 2728 2746 +18
============================================
- Hits 38487 37901 -586
- Misses 92637 95981 +3344
- Partials 1580 1598 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0aa5226
to
28d1ffa
Compare
5754519
to
585fb3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed everything yet, but here's the first batch of comments. The PR is really good 👍
bec8381
to
3972b96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! It looks good to me.
Important
Can you run cargo fmt with the following format config: #7049
Note
It's difficult for me to review the kubernetes.rs
file since I'm not familiar with how k8s works.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## dev #7103 +/- ##
=============================================
- Coverage 28.07% 10.90% -17.18%
=============================================
Files 1288 673 -615
Lines 157729 113438 -44291
Branches 3121 1118 -2003
=============================================
- Hits 44283 12368 -31915
+ Misses 111569 99958 -11611
+ Partials 1877 1112 -765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
27d726e
to
e3b8c7b
Compare
39d4597
to
ba5ee04
Compare
1c7373c
to
117cbf3
Compare
Tested Kubernetes driver against a real kubernetes cluster deployed for the tests. Worked properly. |
Since I started to work on this PR, we've revamped at multiple occasion the architecture of the scalable Async RPC. We ended up on something really different that what was first envisioned. Closing this PR in favor of a one against with a new branch. |
This PR holds the whole modifications for making OSRD async using a RabbitMQ. This is a work in progress, here is an overview:
Closes #6679, #6680, #6681
Helm cart related PR : OpenRailAssociation/osrd-chart#11