Skip to content

Commit

Permalink
Make a change to the macos build to explore why the github macos CI i…
Browse files Browse the repository at this point in the history
…s crapping out

over libarclite (an old reference counting support lib for objective-C we don't use).
Change the minimum deployment target on macos64x86_64 from 10.9 to 10.13.
Use -fobjc-abi-version=3 instead of -fobjc-link-runtime
  • Loading branch information
eliotmiranda committed Dec 2, 2024
1 parent a7eed30 commit cbbef8e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion building/macos64ARMv8/common/Makefile.flags
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ WARNINGS:= -Wno-missing-field-initializers -Wno-missing-prototypes \
-Wno-trigraphs -Wdeprecated-declarations -Wimplicit-function-declaration

# N.B. No QuickTime framework; that is 32-bit only.
FRAMEWORKS?=-fobjc-link-runtime \
FRAMEWORKS?=-fobjc-abi-version=3 \
-framework Foundation -framework OpenGL -framework Cocoa \
-framework AudioToolbox -framework CoreAudio -framework AVFoundation \
-framework SystemConfiguration \
Expand Down
4 changes: 2 additions & 2 deletions building/macos64x64/common/Makefile.flags
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ifeq ($(strip $(SDK)),)
endif
TARGET_ARCH:=x86_64
ifeq ($(TARGET_VERSION_MIN),) # Allow Makefile to set TARGET_VERSION_MIN
TARGET_VERSION_MIN:=10.9
TARGET_VERSION_MIN:=10.13
endif

# Determine where to install plugins in the .app bundle using the Squeak
Expand Down Expand Up @@ -76,7 +76,7 @@ WARNINGS:= -Wno-missing-field-initializers -Wno-missing-prototypes \
-Wno-trigraphs -Wdeprecated-declarations -Wimplicit-function-declaration

# N.B. No QuickTime framework; that is 32-bit only.
FRAMEWORKS?=-fobjc-link-runtime \
FRAMEWORKS?=-fobjc-abi-version=3 \
-framework Foundation -framework OpenGL -framework Cocoa \
-framework AudioToolbox -framework CoreAudio -framework AVFoundation \
-framework SystemConfiguration \
Expand Down

0 comments on commit cbbef8e

Please sign in to comment.