Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: complete migration of isa-related logic to isa.mk #608

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: complete migration of isa-related logic to isa.mk #608

wants to merge 2 commits into from

Conversation

xyyy1420
Copy link
Contributor

No description provided.

@xyyy1420 xyyy1420 requested a review from shinezyy October 28, 2024 10:55
@xyyy1420 xyyy1420 marked this pull request as ready for review October 28, 2024 10:56
shinezyy
shinezyy reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@shinezyy shinezyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But can you add some motivation why we do this? just for code clean-up or for other features?

@xyyy1420
Copy link
Contributor Author

LGTM. But can you add some motivation why we do this? just for code clean-up or for other features?

The original build command is make ISA=xxx, ISA variable is passed directly into make via the command, but now we're using menuconfig, ISA variable is passed into make by writting auto.conf file, so in order for tools/xxx/Makefile to work, we need to organize the logic related to the ISA variables into isa.mk and then include it in tools/xxx/Makefile

shinezyy
shinezyy approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@shinezyy shinezyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz squash commits, and add motivation into commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinezyy shinezyy shinezyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xyyy1420 @shinezyy