Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbltrp): align logic of sdt with xiangshan #60

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

lewislzh
Copy link

@lewislzh lewislzh commented Nov 27, 2024

No description provided.

@lewislzh lewislzh requested a review from huxuan0307 November 27, 2024 07:36
@lewislzh lewislzh force-pushed the fix-dbltrp branch 4 times, most recently from 726acee to 9ba1b39 Compare November 28, 2024 02:11
  * align vsstatus.sdt/henvcfg.DTE interaction logic with xiangshan
    * as vsstatus is not aliase of otther CSR fields and SDT is controlled
      by henvcfg.DTE. According to the manual, when the read/write property
      of **sdt** changes from **RO** to **RW**, its immediate value becomes
      **UNSPECIFIED** but valid. XiangShan adopts the simplest hardware
      implementation, allowing **vsstatus.sdt** to be written when **DTE**
      is disabled, while reads are masked by **DTE**. In contrast, Spike
      employs a design where both reads and writes are masked. To align the
      behavior of **vsstatus.sdt** in Spike with XiangShan during comparison,
      we adjust Spike's write behavior under **DTE**-disabled conditions to match XiangShan's.
  * add mstatus.sdt/sie, mstatus.mdt/mie missing interatcion logic.
    when sdt/mdt write 1, sie/mie will clear.
@huxuan0307 huxuan0307 merged commit ad9bf36 into difftest Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Modification of xstatus WPRI Field During menvcfg Reads/Writes
2 participants