-
Notifications
You must be signed in to change notification settings - Fork 179
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(abr-testing): Fix DVT1ABR3 plate type and liquid set up (#16971)
<!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview Fixed DVT1ABR3 Protocol and Updated liquid setup. ## Test Plan and Hands on Testing <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> ## Changelog - removed abr3 csv file since the protocol no longer uses it - updated liquid set up for abr3 - changed 96 well plate to flat bottom for better compatibility with the plate reader. ## Review requests <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> ## Risk assessment <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
- Loading branch information
Showing
3 changed files
with
56 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 0 additions & 25 deletions
25
abr-testing/abr_testing/protocols/csv_parameters/3_samplevols.csv
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
"""Plate Filler Protocol for Simple Normalize Long.""" | ||
"""Plate Filler Protocol for Tartrazine Protocol.""" | ||
from opentrons import protocol_api | ||
from abr_testing.protocols.helpers import ( | ||
load_common_liquid_setup_labware_and_instruments, | ||
) | ||
|
||
metadata = { | ||
"protocolName": "DVT1ABR3 Liquids: Flex Normalize with Tubes", | ||
"protocolName": "DVT1ABR3 Liquids: Tartrazine Protocol", | ||
"author": "Rhyann clarke <[email protected]>", | ||
"source": "Protocol Library", | ||
} | ||
|
@@ -32,9 +32,16 @@ def run(protocol: protocol_api.ProtocolContext) -> None: | |
) | ||
# Transfer Liquid | ||
p1000.transfer( | ||
4000, | ||
45000, | ||
source_reservoir["A1"], | ||
reagent_tube["A1"].top(), | ||
reagent_tube["B3"].top(), | ||
blowout=True, | ||
blowout_location="source well", | ||
) | ||
p1000.transfer( | ||
45000, | ||
source_reservoir["A1"], | ||
reagent_tube["A4"].top(), | ||
blowout=True, | ||
blowout_location="source well", | ||
) |