fix(api): truncate plate reader floating point results to third decimal place #16919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-1271
to
+1274
| well_map[well_key] = value | ||
| truncated_value = float( | ||
| "{:.5}".format(str(value)) | ||
| ) # Truncate the returned value to the third decimal place | ||
| well_map[well_key] = truncated_value |
There was a problem hiding this comment.
round(value, 3) instead of going back and forth to a str?
There was a problem hiding this comment.
We didn't want to round the read results, we want the exact reading value from the reader but truncated to the third decimal place.
There was a problem hiding this comment.
This does round, though.
>>> "{:.5}".format(123.45678)
'123.46'It also goes to more than 3 decimal places if the integer part is too short:
>>> "{:.5}".format(1.23456)
'1.2346'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Covers EXEC-1019
Ensure that the plate reader values are truncated to the third decimal place after being read during a protocol. This value should both be returned during a protocol run and as a part of the CSV file saved.
Test Plan and Hands on Testing
Changelog
Added truncation formatting step to plate reader read result formatting method.
Review requests
Small change, anything look awry? Truncating to 5 characters total should cover us here because the plate reader only supports readings between 0 and 4 on a whole-number scale.
Risk assessment
Low - affects new behavior for 8.2 read result only.