Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): raise error during analysis plate reader read without lid closed #16941

Merged
merged 2 commits into from
Nov 21, 2024
+4 −0
Merged

fix(api): raise error during analysis plate reader read without lid closed #16941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d747f3
addition of error during analysis when attempting to read without clo…
CaseyBatten Nov 21, 2024
ef9358f
Update api/src/opentrons/protocol_engine/commands/absorbance_reader/r…
CaseyBatten Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/src/opentrons/protocol_engine/commands/absorbance_reader/read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ async def execute( # noqa: C901
raise CannotPerformModuleAction(
"Cannot perform Read action on Absorbance Reader without calling `.initialize(...)` first."
)
if abs_reader_substate.is_lid_on is False:
raise CannotPerformModuleAction(
"Absorbance Plate Reader can't read a plate with the lid open. Call `close_lid()` first."
)

# TODO: we need to return a file ID and increase the file count even when a moduel is not attached
if (
Expand Down
Loading