Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Secret customization #285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Secret customization #285

wants to merge 2 commits into from

Conversation

koushyk
Copy link

@koushyk koushyk commented May 14, 2021

Added possibility to change type of secret and its name

Copy link
Contributor

@rjkernick rjkernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few other items would need changed in the chart in order for this to work properly. The version in chart.yaml would also need changed

@@ -2,7 +2,7 @@
apiVersion: v1
kind: Secret
metadata:
name: {{ template "nexus.name" . }}-secret
name: {{ toYaml .Values.secret.metadata.name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need changed in the places that use the secret as well. I recommend adding something to the helpers.tpl and ensuring that all references that use the secret use the function you create in the helpers.tpl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants