Skip to content

PowerPoint 2007 Reader/Writer : Improvements on Font, RichText, Thumbnail, Presentation Properties & Shadow #333

PowerPoint 2007 Reader/Writer : Improvements on Font, RichText, Thumbnail, Presentation Properties & Shadow

PowerPoint 2007 Reader/Writer : Improvements on Font, RichText, Thumbnail, Presentation Properties & Shadow #333

Triggered via pull request December 13, 2023 14:02
Status Failure
Total duration 2m 37s
Artifacts

php.yml

on: pull_request
PHP CS Fixer
58s
PHP CS Fixer
PHP Mess Detector
33s
PHP Mess Detector
Matrix: PHP Static Analysis
Matrix: PHPUnit
Matrix: Check samples
Fit to window
Zoom out
Zoom in

Annotations

98 errors and 26 warnings
PHPUnit (7.1)
Process completed with exit code 2.
PHPUnit (7.2)
Process completed with exit code 2.
PHPUnit (7.3)
Process completed with exit code 2.
PHP Static Analysis (7.1): src/PhpPresentation/AbstractShape.php#L1
ParseError (syntax error, unexpected '?', expecting function (T_FUNCTION) or const (T_CONST)) thrown while looking for class PhpOffice\PhpPresentation\AbstractShape.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L78
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnail has no type specified.
PHP Static Analysis (7.1): src/PhpPresentation/GeometryCalculator.php#L1
ParseError (syntax error, unexpected '?', expecting function (T_FUNCTION) or const (T_CONST)) thrown while looking for class PhpOffice\PhpPresentation\AbstractShape.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L83
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailPath has no type specified.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L88
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailType has no type specified.
PHP Static Analysis (7.1): src/PhpPresentation/GeometryCalculator.php#L39
ParseError (syntax error, unexpected '?', expecting function (T_FUNCTION) or const (T_CONST)) thrown while looking for class PhpOffice\PhpPresentation\AbstractShape.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L137
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() has invalid return type PhpOffice\PhpPresentation\binary.
PHP Static Analysis (7.1): src/PhpPresentation/PresentationProperties.php#L78
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnail has no type specified.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L142
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns string|false.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L149
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns null.
PHP Static Analysis (7.1): src/PhpPresentation/PresentationProperties.php#L83
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailPath has no type specified.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has no return type specified.
PHP Static Analysis (7.1): src/PhpPresentation/PresentationProperties.php#L88
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailType has no type specified.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $content with no type specified.
PHP Static Analysis (7.1): src/PhpPresentation/PresentationProperties.php#L137
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() has invalid return type PhpOffice\PhpPresentation\binary.
PHP Static Analysis (7.1): src/PhpPresentation/PresentationProperties.php#L142
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns string|false.
PHP Static Analysis (8.3): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $type with no type specified.
PHP Static Analysis (7.1): src/PhpPresentation/PresentationProperties.php#L149
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns null.
PHP Static Analysis (8.3): src/PhpPresentation/Reader/PowerPoint2007.php#L233
Syntax error, unexpected ')', expecting ']' on line 233
PHP Static Analysis (7.1): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has no return type specified.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L78
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnail has no type specified.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L83
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailPath has no type specified.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L88
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailType has no type specified.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L137
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() has invalid return type PhpOffice\PhpPresentation\binary.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L142
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns string|false.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L149
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns null.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has no return type specified.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $content with no type specified.
PHP Static Analysis (7.2): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $type with no type specified.
PHP Static Analysis (7.2): src/PhpPresentation/Reader/PowerPoint2007.php#L233
Syntax error, unexpected ')', expecting ']' on line 233
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L78
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnail has no type specified.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L83
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailPath has no type specified.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L88
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailType has no type specified.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L137
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() has invalid return type PhpOffice\PhpPresentation\binary.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L142
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns string|false.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L149
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns null.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has no return type specified.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $content with no type specified.
PHP Static Analysis (7.3): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $type with no type specified.
PHP Static Analysis (7.3): src/PhpPresentation/Reader/PowerPoint2007.php#L233
Syntax error, unexpected ')', expecting ']' on line 233
PHP Mess Detector
Process completed with exit code 3.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L78
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnail has no type specified.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L83
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailPath has no type specified.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L88
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailType has no type specified.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L137
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() has invalid return type PhpOffice\PhpPresentation\binary.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L142
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns string|false.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L149
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns null.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has no return type specified.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $content with no type specified.
PHP Static Analysis (7.4): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $type with no type specified.
PHP Static Analysis (7.4): src/PhpPresentation/Reader/PowerPoint2007.php#L233
Syntax error, unexpected ')', expecting ']' on line 233
Check samples (7.2)
Process completed with exit code 255.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L78
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnail has no type specified.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L83
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailPath has no type specified.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L88
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailType has no type specified.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L137
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() has invalid return type PhpOffice\PhpPresentation\binary.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L142
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns string|false.
Check samples (7.3)
Process completed with exit code 255.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L149
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns null.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has no return type specified.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $content with no type specified.
PHP Static Analysis (8.0): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $type with no type specified.
PHP Static Analysis (8.0): src/PhpPresentation/Reader/PowerPoint2007.php#L233
Syntax error, unexpected ')', expecting ']' on line 233
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L78
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnail has no type specified.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L83
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailPath has no type specified.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L88
Property PhpOffice\PhpPresentation\PresentationProperties::$thumbnailType has no type specified.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L137
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() has invalid return type PhpOffice\PhpPresentation\binary.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L142
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns string|false.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L149
Method PhpOffice\PhpPresentation\PresentationProperties::getThumbnail() should return PhpOffice\PhpPresentation\binary but returns null.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has no return type specified.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $content with no type specified.
PHP Static Analysis (8.1): src/PhpPresentation/PresentationProperties.php#L155
Method PhpOffice\PhpPresentation\PresentationProperties::setThumbnailPath() has parameter $type with no type specified.
PHP Static Analysis (8.1): src/PhpPresentation/Reader/PowerPoint2007.php#L233
Syntax error, unexpected ')', expecting ']' on line 233
Check samples (7.4)
Process completed with exit code 255.
Check samples (7.1)
Process completed with exit code 255.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php#L829
Method PhpOffice\PhpPresentation\Writer\PowerPoint2007\AbstractSlide::writeEffect() has no return type specified.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php#L829
Method PhpOffice\PhpPresentation\Writer\PowerPoint2007\AbstractSlide::writeEffect() has parameter $aEffect with no value type specified in iterable type array.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php#L829
PHPDoc tag @param has invalid value (array \PhpOffice\PhpPresentation\Style\Effect[]): Unexpected token "\\PhpOffice\\PhpPresentation\\Style\\Effect", expected variable at offset 79
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php#L829
PHPDoc tag @param references unknown parameter: $oShadow
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php#L832
Call to function is_array() with null will always evaluate to false.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/DocPropsThumbnail.php#L47
Parameter #1 $data of function imagecreatefromstring expects string, PhpOffice\PhpPresentation\binary given.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/PptCharts.php#L453
Parameter #1 $condition of method PhpOffice\Common\XMLWriter::writeAttributeIf() expects bool, int given.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/PptCharts.php#L454
Parameter #1 $condition of method PhpOffice\Common\XMLWriter::writeAttributeIf() expects bool, int given.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/PptCharts.php#L615
Parameter #1 $condition of method PhpOffice\Common\XMLWriter::writeAttributeIf() expects bool, int given.
PHP Static Analysis (8.2): src/PhpPresentation/Writer/PowerPoint2007/PptCharts.php#L616
Parameter #1 $condition of method PhpOffice\Common\XMLWriter::writeAttributeIf() expects bool, int given.
Check samples (8.1)
Process completed with exit code 255.
Check samples (8.0)
Process completed with exit code 255.
Check samples (8.2)
Process completed with exit code 255.
PHP CS Fixer
Process completed with exit code 12.
Check samples (8.3)
Process completed with exit code 255.
PHPUnit (8.0)
Process completed with exit code 2.
PHPUnit (7.4)
Process completed with exit code 2.
PHPUnit (8.1)
Process completed with exit code 2.
PHPUnit (8.3)
Process completed with exit code 2.
PHPUnit (8.2)
Process completed with exit code 2.
PHPUnit (7.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPUnit (7.2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPUnit (7.3)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (7.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (8.3)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (7.2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (7.3)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Mess Detector
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (7.4)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (7.2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (8.0)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (7.3)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (8.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (7.4)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (7.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Static Analysis (8.2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (8.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (8.0)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (8.2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP CS Fixer
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check samples (8.3)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPUnit (8.0)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPUnit (7.4)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPUnit (8.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPUnit (8.3)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPUnit (8.2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/