Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed missing images #829 #833

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: Fixed missing images #829 #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9675b5b
fix: Fixed missing images #829
kw-pr Dec 12, 2024
533b463
fix: tests and double addShape
kw-pr Dec 12, 2024
374a1e1
Merge branch 'master' into patch-4
kw-pr Dec 12, 2024
b6a83c6
chore: restored Sample_05_Chart.php setShadow() (not working correct…
kw-pr Dec 12, 2024
8623323
Merge remote-tracking branch 'origin/patch-4' into patch-4
kw-pr Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changes/1.2.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
## Bug fixes

- Word2007 Reader: Fixed cast of spacing fixing [#729](https://github.com/PHPOffice/PHPPresentation/pull/729), [#796](https://github.com/PHPOffice/PHPPresentation/pull/796) in [#818](https://github.com/PHPOffice/PHPPresentation/pull/818)
- Word2007 Writer: Fixed missing images by [@kw-pr](https://github.com/kw-pr) [#829](https://github.com/PHPOffice/PHPPresentation/pull/829)
- CI : Fixed PHPCSFixer by [@kw-pr](https://github.com/kw-pr) in [#835](https://github.com/PHPOffice/PHPPresentation/pull/835)

## Miscellaneous
Expand Down
2 changes: 1 addition & 1 deletion src/PhpPresentation/Slide/AbstractSlide.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ public function createChartShape(): Chart
public function createDrawingShape(): File
{
$shape = new File();
$this->addShape($shape);
$shape->setContainer($this);

return $shape;
}
Expand Down
Loading