Fix issue where disableAutomaticSaving did not work when `useParent…

…NavigationBar` was enabled. (#389) * Disable the `autosaveEnabled` configuration option when disabling autosave via the `disableAutomaticSaving` prop * Bump version to 1.30.7
PSPDFKit · Feb 9, 2021 · 33e2560 · 33e2560
1 parent 191ff5d
commit 33e2560
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/ios/RCTPSPDFKit/RCTPSPDFKitViewManager.m b/ios/RCTPSPDFKit/RCTPSPDFKitViewManager.m
@@ -98,7 +98,15 @@ @implementation RCTPSPDFKitViewManager
 
 RCT_EXPORT_VIEW_PROPERTY(disableDefaultActionForTappedAnnotations, BOOL)
 
-RCT_EXPORT_VIEW_PROPERTY(disableAutomaticSaving, BOOL)
+RCT_CUSTOM_VIEW_PROPERTY(disableAutomaticSaving, BOOL, RCTPSPDFKitView) {
+  if (json) {
+    view.disableAutomaticSaving = [RCTConvert BOOL:json];
+    [view.pdfController updateConfigurationWithBuilder:^(PSPDFConfigurationBuilder *builder) {
+      // Disable autosave in the configuration.
+      builder.autosaveEnabled = !view.disableAutomaticSaving;
+    }];
+  }
+}
 
 RCT_REMAP_VIEW_PROPERTY(color, tintColor, UIColor)
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pspdfkit",
-  "version": "1.30.6",
+  "version": "1.30.7",
   "description": "A React Native module for the PSPDFKit library.",
   "keywords": [
     "react native",

diff --git a/samples/Catalog/package.json b/samples/Catalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "Catalog",
-  "version": "1.30.6",
+  "version": "1.30.7",
   "private": true,
   "scripts": {
     "start": "react-native start",

diff --git a/samples/NativeCatalog/package.json b/samples/NativeCatalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "NativeCatalog",
-  "version": "1.30.6",
+  "version": "1.30.7",
   "private": true,
   "scripts": {
     "android": "react-native run-android",