Merge pull request #284 from PSPDFKit/rad/fix-invalid-instant-json-pa…

…yload-crash Fix a crash that would occur when adding an invalid Instant JSON payload
PSPDFKit · Aug 28, 2019 · 40b46cb · 40b46cb
2 parents eb2a80f + 40ee276
commit 40b46cb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/ios/RCTPSPDFKit/RCTPSPDFKitView.m b/ios/RCTPSPDFKit/RCTPSPDFKitView.m
@@ -212,7 +212,9 @@ - (BOOL)addAnnotation:(id)jsonAnnotation error:(NSError *_Nullable *)error {
   BOOL success = NO;
   if (data) {
     PSPDFAnnotation *annotation = [PSPDFAnnotation annotationFromInstantJSON:data documentProvider:documentProvider error:error];
-    success = [document addAnnotations:@[annotation] options:nil];
+    if (annotation) {
+      success = [document addAnnotations:@[annotation] options:nil];
+    }
   }
 
   if (!success) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pspdfkit",
-  "version": "1.25.5",
+  "version": "1.25.6",
   "description": "A React Native module for the PSPDFKit library.",
   "keywords": [
     "react native",

diff --git a/samples/Catalog/package.json b/samples/Catalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "Catalog",
-  "version": "1.25.5",
+  "version": "1.25.6",
   "private": true,
   "scripts": {
     "start": "react-native start",