Remove the trial license key requirement (#403)

* Remove trial license key requirement * Apply suggestions from code review Co-authored-by: Stefan Kieleithner <[email protected]> * Bump version number to 1.31.0 * Update README.md Co-authored-by: Stefan Kieleithner <[email protected]> * Update Github pull request template Co-authored-by: Stefan Kieleithner <[email protected]>
PSPDFKit · May 26, 2021 · ae764b3 · ae764b3
1 parent d5a66ca
commit ae764b3
Show file tree

Hide file tree

Showing 15 changed files with 223 additions and 233 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -3,5 +3,5 @@
 
 # Acceptance Criteria
 
-- [ ] When approved, right before merging, rebase with master and increment the package version in `package.json`, `package-lock.json`, `samples/Catalog/package.json`, and `samples/NativeCatalog/package.json` (see example commit:  https://github.com/PSPDFKit/react-native/pull/389/commits/ae027329b5380906fa778354945178c7e92730a4).
+- [ ] When approved, right before merging, rebase with master and increment the package version in `package.json`, `package-lock.json`, `samples/Catalog/package.json`, `samples/Catalog/yarn.lock`, `samples/NativeCatalog/package.json`, and `samples/NativeCatalog/yarn.lock` (see example commit:  https://github.com/PSPDFKit/react-native/pull/403/commits/b32b4edd97ee9b49c51c8b932e2bf477744c2b24).
 - [ ] Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).
diff --git a/README.md b/README.md
diff --git a/android/build.gradle b/android/build.gradle
@@ -15,7 +15,7 @@
  *   Contains gradle configuration constants
  */
 ext {
-    PSPDFKIT_VERSION = '6.6.0'
+    PSPDFKIT_VERSION = '6.6.2'
 }
 
 buildscript {

diff --git a/android/src/main/java/com/pspdfkit/react/PSPDFKitModule.java b/android/src/main/java/com/pspdfkit/react/PSPDFKitModule.java
@@ -182,7 +182,7 @@ public void run() {
     }
 
     @ReactMethod
-    public void setLicenseKey(@NonNull String licenseKey) {
+    public void setLicenseKey(@Nullable String licenseKey) {
         PSPDFKit.initialize(getReactApplicationContext().getApplicationContext(), licenseKey);
     }
 

diff --git a/ios/RCTPSPDFKit/RCTPSPDFKitManager.m b/ios/RCTPSPDFKit/RCTPSPDFKitManager.m
@@ -24,13 +24,9 @@ @implementation RCTPSPDFKitManager
 
 RCT_EXPORT_MODULE(PSPDFKit)
 
-RCT_REMAP_METHOD(setLicenseKey, setLicenseKey:(NSString *)licenseKey resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
-  if (licenseKey.length > 0) {
-    [PSPDFKitGlobal setLicenseKey:licenseKey];
-    resolve(@(YES));
-  } else {
-    reject(@"error", @"Invalid License Key.", nil);
-  }
+RCT_REMAP_METHOD(setLicenseKey, setLicenseKey:(nullable NSString *)licenseKey resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
+  [PSPDFKitGlobal setLicenseKey:licenseKey];
+  resolve(@(YES));
 }
 
 RCT_REMAP_METHOD(present, present:(PSPDFDocument *)document withConfiguration:(PSPDFConfiguration *)configuration resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pspdfkit",
-  "version": "1.30.18",
+  "version": "1.31.0",
   "description": "A React Native module for the PSPDFKit library.",
   "keywords": [
     "react native",

diff --git a/samples/Catalog/package.json b/samples/Catalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "Catalog",
-  "version": "1.30.18",
+  "version": "1.31.0",
   "private": true,
   "scripts": {
     "start": "react-native start",

diff --git a/samples/Catalog/yarn.lock b/samples/Catalog/yarn.lock
@@ -5420,7 +5420,7 @@ react-native-permissions@^1.1.1:
   integrity sha512-t0Ujm177bagjUOSzhpmkSz+LqFW04HnY9TeZFavDCmV521fQvFz82aD+POXqWsAdsJVOK3umJYBNNqCjC3g0hQ==
 
 "react-native-pspdfkit@file:../..":
-  version "1.30.18"
+  version "1.31.0"
 
 react-native-qrcode-scanner@^1.2.1:
   version "1.2.1"

diff --git a/samples/NativeCatalog/package.json b/samples/NativeCatalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "NativeCatalog",
-  "version": "1.30.18",
+  "version": "1.31.0",
   "private": true,
   "scripts": {
     "android": "react-native run-android",

diff --git a/samples/NativeCatalog/yarn.lock b/samples/NativeCatalog/yarn.lock
@@ -5511,7 +5511,7 @@ react-native-gesture-handler@^1.3.0:
     prop-types "^15.7.2"
 
 "react-native-pspdfkit@file:../..":
-  version "1.30.18"
+  version "1.31.0"
 
 react-native-safe-area-view@^0.14.1:
   version "0.14.8"

diff --git a/screenshots/adding-pdf.png b/screenshots/adding-pdf.png
diff --git a/screenshots/deployment-target.png b/screenshots/deployment-target.png
diff --git a/screenshots/drag-and-drop-document.png b/screenshots/drag-and-drop-document.png
diff --git a/screenshots/view-controller-based-status-bar-appearance.png b/screenshots/view-controller-based-status-bar-appearance.png