Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat(module/asg): Introduce Instance Refresh for ASG module #418

Closed
wants to merge 6 commits into from

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Dec 18, 2023

Description

PR introduces new feature for ASG module - instance refresh, which can be customized by allowing to change every possible attribute for instance refresh block.

Motivation and Context

#416

How Has This Been Tested?

Code was tested by extending example isolated_design_autoscale and deploying it in the lab.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech added aws enhancement New feature or request labels Dec 18, 2023
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Dec 18, 2023

/help

ChatOPS built in help:

Currently supported commands include:

  • /sca - run all SCA tests via pre-commit
  • /validate - run terraform validate
  • /plan - plan the infrastructure (only examples)
  • /apply - deploy the infrastructure and destroy afterwards (only examples)
  • /idempotence - test idempotence: deploy, plan and destroy afterwards (only examples).

The 1st command does not take arguments, the remaining take two:

  • paths - a space delimitied list of module paths
  • tf_version - (optional, defaults to the latest available) a space delimited list of Terraform versions to test the infrastrucure against.

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/combined_design examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"
# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vpc examples/combined_design"

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Dec 18, 2023

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale"

Testing job ID: 7253921886
Job result: SUCCESS

@sebastianczech sebastianczech marked this pull request as ready for review December 18, 2023 21:43
@sebastianczech sebastianczech requested a review from a team as a code owner December 18, 2023 21:43
@sebastianczech
Copy link
Contributor Author

Changes are going to be deployed in new repository in PR PaloAltoNetworks/terraform-aws-swfw-modules#3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant