Improve Jena scraper (now uses api instead of html) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jena has a comprehensive api available at https://opendata.jena.de/dataset/parken
The api supports many features which are not available in v2 yet (basically everything in the docs/schema/parking-site.json besides free specific lots like
realtime_capacity_charging),but also useful features that are not available at all in ParkAPI as far as i can see as pricing.
I have commented out code that is used to parse opening hours since i had already written that for v1. I can delete that if you want.
Also did charging hours vanish during the upgrade to v2? I think it would be quite useful.
The geojson is not needed anymore as everything is available in the api.