Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scraper geojson origin #74

Closed
wants to merge 1 commit into from
Closed

Conversation

the-infinity
Copy link
Contributor

The scraper loaded data from wrong sources. This MR fixes that.

@the-infinity the-infinity requested a review from hbruch February 17, 2024 09:27
@hbruch
Copy link
Contributor

hbruch commented Feb 19, 2024

"Loaded from the wrong source" is not quite right. As the method states, it fetched the data from the old ParkAPI repo, which was reasonable during development of v2, as long as v1 received the maintenance updates.

Since this will not be the case any longer, reading from a remote repo does not make sense IMO. If required, the baseline should be read from the local files. Keeping those local geojson files still makes sense for those sources, which do not provide the static information. Via theses static files, they could be gathered and extended manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants