-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 #219
Open
the-infinity
wants to merge
1
commit into
main
Choose a base branch
from
python-3-12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Python 3.12 #219
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,34 @@ | ||
FROM ubuntu:22.04 | ||
|
||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
# Upgrade packages and install locales | ||
RUN echo "locales locales/default_environment_locale select en_US.UTF-8" | debconf-set-selections && \ | ||
echo "locales locales/locales_to_be_generated select en_US.UTF-8 UTF-8" | debconf-set-selections && \ | ||
apt-get update && \ | ||
apt-get upgrade -y && \ | ||
apt-get install -y locales | ||
|
||
ENV LANG=en_US.UTF-8 \ | ||
LC_ALL=en_US.UTF-8 \ | ||
LANGUAGE=en_US:en | ||
|
||
ENV PYTHONUNBUFFERED=1 \ | ||
PYTHONDONTWRITEBYTECODE=1 | ||
|
||
# Install commonly used packages | ||
# - libssl-dev, libffi-dev: required for Python cryptography module | ||
RUN apt-get install -y \ | ||
python3-pip \ | ||
python3-dev \ | ||
build-essential \ | ||
libssl-dev \ | ||
libffi-dev \ | ||
inotify-tools \ | ||
wait-for-it \ | ||
git \ | ||
wget | ||
|
||
# Create symlinks /usr/bin/python and /usr/bin/pip, but only if these files don't exist yet | ||
RUN { [ -e /usr/bin/python ] || ln -s /usr/bin/python3 /usr/bin/python; } && \ | ||
{ [ -e /usr/bin/pip ] || ln -s /usr/bin/pip3 /usr/bin/pip; } | ||
|
||
RUN mkdir -p /app | ||
WORKDIR /app | ||
|
||
COPY ./requirements.txt requirements-dev.txt . | ||
RUN pip install --upgrade pip && \ | ||
pip install -r requirements.txt -r requirements-dev.txt | ||
|
||
CMD ["python3", "runserver.py"] | ||
EXPOSE 5000 | ||
FROM ubuntu:24.04 | ||
|
||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
# Upgrade packages and install locales | ||
RUN echo "locales locales/default_environment_locale select en_US.UTF-8" | debconf-set-selections && \ | ||
echo "locales locales/locales_to_be_generated select en_US.UTF-8 UTF-8" | debconf-set-selections && \ | ||
apt-get update && \ | ||
apt-get upgrade -y && \ | ||
apt-get install -y locales | ||
|
||
ENV LANG=en_US.UTF-8 \ | ||
LC_ALL=en_US.UTF-8 \ | ||
LANGUAGE=en_US:en | ||
|
||
ENV PYTHONUNBUFFERED=1 \ | ||
PYTHONDONTWRITEBYTECODE=1 | ||
|
||
# Install commonly used packages | ||
# - libssl-dev, libffi-dev: required for Python cryptography module | ||
RUN apt-get install -y python3-pip | ||
|
||
# Create symlinks /usr/bin/python and /usr/bin/pip, but only if these files don't exist yet | ||
RUN { [ -e /usr/bin/python ] || ln -s /usr/bin/python3 /usr/bin/python; } && \ | ||
{ [ -e /usr/bin/pip ] || ln -s /usr/bin/pip3 /usr/bin/pip; } | ||
|
||
RUN mkdir -p /app | ||
WORKDIR /app | ||
|
||
COPY ./requirements.txt requirements-dev.txt . | ||
RUN pip install --break-system-packages -r requirements.txt -r requirements-dev.txt | ||
|
||
CMD ["python3", "runserver.py"] | ||
EXPOSE 5000 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
FROM ubuntu:22.04 | ||
FROM ubuntu:24.04 | ||
|
||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why every line is shown as being changed? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, for some reason, this file had Windows line breaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick]
Can you move the changes into a separate commit, so that it can be ignored more easily when
git blame
-ing?