VRN Realtime Pull Converter: Park and Ride #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-infinity
approved these changes
Oct 18, 2024
| import_parking_site_exceptions: list[ImportParkingSiteException] = [] | ||
|
|
||
| response = requests.get( | ||
| url='https://spatial.vrn.de/data/rest/services/Hosted/p_r_parkapi_static/FeatureServer/5/query?where=objectid%3E0&outFields=*&returnGeometry=true&f=geojson', |
| for feature_input in feature_inputs: | ||
| static_parking_site_inputs_by_uid[str(feature_input.properties.vrn_sensor_id)] = feature_input.to_static_parking_site_input() | ||
|
|
||
| for realtime_vrn_p_r_input in realtime_vrn_p_r_inputs: |
There was a problem hiding this comment.
Is it by purpose that you ignore all datasets which don't have realtime data?
| parking_site_uid = str(realtime_vrn_p_r_input.uid) | ||
| if parking_site_uid in static_parking_site_inputs_by_uid: | ||
| # Update realtime data with only parking places having static data | ||
| realtime_vrn_p_r_input.uid = static_parking_site_inputs_by_uid[parking_site_uid].uid |
There was a problem hiding this comment.
Why do you do it this way?
|
The Verkehrsverbund Rhein-Neckar wants to bundle the data sources and make it available via one Interface (their GIS-System), which conforms with Open Data License Germany. Therefore, Instead of pulling data from 3 different data providers' APIs (as it is currently programmed in this converter) only one data source will be used. I will suspend the development of this converter till November when the new real-time interface will be ready. |
|
Please keep in mind to rebase it as soon as it gets ready, as there was a ruff update which changed formatting rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the Park and Ride realtime data from Verkehrsverbund Rhein-Neckar GmbH. The converter pulls static data made available via a URL, and the realtime data are pulled from Multiguide API and Sonah API, and bundled together.