Add bahnv2 bike parking locked and open #172
Conversation
…bidata-bw/parkapi-sources-v3 into add-bahnv2-bike-parking-sites
| @@ -70,3 +60,39 @@ def get_data(self) -> dict: | |||
| timeout=60, | |||
| ) | |||
| return response.json() | |||
|
|
|||
|
|
|||
| class BahnV2PullConverter(BahnV2BasePullConverter): | |||
There was a problem hiding this comment.
Why creating three different converters for the same source? You can collect different purpose in the same source. This would have the advantage of not doing the same requests three times and therefore to prevent rate limits, and to have a simpler config and data handling.
There was a problem hiding this comment.
You are right with the rate limit!
| @@ -26,6 +33,13 @@ def map_static_parking_site(bahn_input: BahnParkingSiteInput) -> StaticParkingSi | |||
| has_realtime_data=False, # TODO: change this as soon as Bahn offers proper rate limits | |||
| static_data_updated_at=datetime.now(tz=timezone.utc), | |||
| public_url=bahn_input.url, | |||
| purpose=next( | |||
There was a problem hiding this comment.
Why looping here at all? I mean, you select the type BahnParkingSiteCapacityType.PARKING anyway?
| @@ -44,3 +58,93 @@ def map_static_parking_site(bahn_input: BahnParkingSiteInput) -> StaticParkingSi | |||
| static_parking_site_input.capacity_disabled = int(round(capacity_data.total)) | |||
|
|
|||
| return static_parking_site_input | |||
|
|
|||
|
|
|||
| class BahnBikeParkingLockedMapper: | |||
There was a problem hiding this comment.
That and the mapper below is almost a 100 % copy of the mapper above. In general, please try to avoid copy-pasting large parts of the code and do OOP. In this case, I wonder why you need different Mappers at all, as this could all be done in one source and one mapper.
There was a problem hiding this comment.
It's now updated.
|
|
||
|
|
||
| @validataclass | ||
| class BahnBikeLockedParkingSiteInput: |
There was a problem hiding this comment.
Same as Mappers: copy paste, and can be removed completely as a single source would work, too.
There was a problem hiding this comment.
Updated, thanks!
This PR updates existing
bahnv2parking source converter by integrating the new capacity typesBIKE_PARKING_LOCKEDandBIKE_PARKING_OPENas separateParkingSitewithtypeofLOCKBOXandOTHERrespectively for bike parking. The existing mappings for car parkingtypeare not changed.The parking sites from Deutsche BahnPark
bahnv2now havepurposeasbikeandcar, grouped intoParkingSiteGroup.