more abstract geojson approach #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGaukrogers
reviewed
Nov 27, 2024
src/parkapi_sources/converters/base_converter/pull/static_geojson_mixin.py
Outdated
Show resolved
Hide resolved
JGaukrogers
reviewed
Nov 27, 2024
| @@ -112,7 +111,8 @@ class HerrenbergBikePropertiesInput(ValidataclassMixin): | |||
| operator_name: OptionalUnset[str] = NoneToUnsetValue(StringValidator(min_length=0, max_length=256)), DefaultUnset | |||
| capacity: int = IntegerValidator(min_value=0) | |||
| capacity_charging: OptionalUnset[int] = NoneToUnsetValue(IntegerValidator(min_value=0)), DefaultUnset | |||
| capacity_cargobike: OptionalUnset[int] = NoneToUnsetValue(IntegerValidator(min_value=0)), DefaultUnset | |||
| # capacity_cargobike is unsupported yet | |||
There was a problem hiding this comment.
Question: is it known when it will be supported? I am wondering if it would help to write the comment as a TODO + number of the issue where it will be fixed, so it's easier to find it later.
There was a problem hiding this comment.
Did not do a TODO, as it is no TODO atm, but linked the ticket: #174
JGaukrogers
reviewed
Nov 27, 2024
JGaukrogers
reviewed
Nov 27, 2024
JGaukrogers
reviewed
Nov 27, 2024
JGaukrogers
reviewed
Nov 27, 2024
JGaukrogers
reviewed
Nov 27, 2024
the-infinity
force-pushed
the
more-abstract-geojson-approach
branch
from
9c053a6 to
5e514df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #168 was running into strange errors during testing, I made the GeoJSON approach a bit more abstract and moved it to a general model.