Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ScimExtensionUtil.java #57

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package edu.psu.swe.scim.util;

import java.util.Collection;
import java.util.Map;

import edu.psu.swe.scim.spec.extension.ScimExtensionRegistry;
import edu.psu.swe.scim.spec.resources.ScimExtension;
import edu.psu.swe.scim.spec.resources.ScimResource;

/**
*
* @author mez5001
*
* This class exposes the SCIM extension methods without requiring that the project using the client knows
* how the ScimExtensionRegistry works
*/
public class ScimExtensionUtil {

/**
* Register a single extension for a single resource
* @param rClass ScimResource class
* @param eClass Extension class
*/
public static void registerExtension(Class<? extends ScimResource> rClass, Class<? extends ScimExtension> eClass) {
ScimExtensionRegistry.getInstance().registerExtension(rClass, eClass);
}

/**
* Register multiple extensions through a map
* @param extensions Map containing all of the ScimResources and the accompanying Extensions
*/
public static void registerExtensions(Map<Class<? extends ScimResource>, Collection<Class<? extends ScimExtension>>> extensions) {
Copy link
Contributor

@smoyer64 smoyer64 May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method signature is a bit awkward ... the user is going to work just as hard (or harder) wrapping up the Map as you are unwrapping it. Might I suggest that we change the signature of the method on line 24 to:

public static void registerExtension(Class<? extends ScimResource> rClass, Class<? extends ScimExtension>... eClass)

And that we eliminate this more complex method. This would require one line of code for each resource class which I think is reasonable.

for(Map.Entry<Class<? extends ScimResource>, Collection<Class<? extends ScimExtension>>> entry : extensions.entrySet()) {
Class<? extends ScimResource> resource = entry.getKey();
for(Class<? extends ScimExtension> extension : entry.getValue()) {
ScimExtensionRegistry.getInstance().registerExtension(resource, extension);
}
}
}
}