-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ScimExtensionUtil.java #57
Open
mez5001
wants to merge
2
commits into
develop
Choose a base branch
from
feature/extenstionUtil
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
scim-client/src/main/java/edu/psu/swe/scim/util/ScimExtensionUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package edu.psu.swe.scim.util; | ||
|
||
import java.util.Collection; | ||
import java.util.Map; | ||
|
||
import edu.psu.swe.scim.spec.extension.ScimExtensionRegistry; | ||
import edu.psu.swe.scim.spec.resources.ScimExtension; | ||
import edu.psu.swe.scim.spec.resources.ScimResource; | ||
|
||
/** | ||
* | ||
* @author mez5001 | ||
* | ||
* This class exposes the SCIM extension methods without requiring that the project using the client knows | ||
* how the ScimExtensionRegistry works | ||
*/ | ||
public class ScimExtensionUtil { | ||
|
||
/** | ||
* Register a single extension for a single resource | ||
* @param rClass ScimResource class | ||
* @param eClass Extension class | ||
*/ | ||
public static void registerExtension(Class<? extends ScimResource> rClass, Class<? extends ScimExtension> eClass) { | ||
ScimExtensionRegistry.getInstance().registerExtension(rClass, eClass); | ||
} | ||
|
||
/** | ||
* Register multiple extensions through a map | ||
* @param extensions Map containing all of the ScimResources and the accompanying Extensions | ||
*/ | ||
public static void registerExtensions(Map<Class<? extends ScimResource>, Collection<Class<? extends ScimExtension>>> extensions) { | ||
for(Map.Entry<Class<? extends ScimResource>, Collection<Class<? extends ScimExtension>>> entry : extensions.entrySet()) { | ||
Class<? extends ScimResource> resource = entry.getKey(); | ||
for(Class<? extends ScimExtension> extension : entry.getValue()) { | ||
ScimExtensionRegistry.getInstance().registerExtension(resource, extension); | ||
} | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method signature is a bit awkward ... the user is going to work just as hard (or harder) wrapping up the Map as you are unwrapping it. Might I suggest that we change the signature of the method on line 24 to:
And that we eliminate this more complex method. This would require one line of code for each resource class which I think is reasonable.