-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint release of "juggernaut" branch matching release Oct 31st 3.30pm #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bakert
commented
Oct 31, 2024
- Give a more sensible message when someone tries to register with no password
- Represent a maybe-not-present season as a nullable int, not as a string
- Log slow queries
- Don't call a link to eventreport.php "eventLink" because that's event.php
- Remove unused import
- Remove redundant func and simplify calling code in TrophyCell
- Remove some unused funcs
- Don't show a big "registered players" heading if we're not going to show any
- Force consistent use of title by making it a required constructor arg
- Don't "self close" img tags, that hasn't been the recommended style since html5
- Don't self close br tags, use html5 preferred style
- Don't self close input tags, in preferred html5 style
- Clean up the last of the self closing html elements, we now use html5 style
- Fix bug in decksearch error display
- Remove HTML from DeckSearch and put it in the template where it belongs
- Remove some tags that don't contribute a lot
- Shush phpstan with an explicit cast in case json_encode returns false
- Clean up masterplayerfile at least enough to satisfy phpstan level 7
- Some phpstan level 7 fixes
- Use json_encode's throw on error to get typesafe result
- Type fixes working towards phpstan level 7
- Move test to ComponentTest where it more correctly belongs
- Undo recent change to getObjectVarsCamelCase
- Remove a hardcoded file_put_contents that hasn't working in 100 million years
- Remove unused funcs
- Always call a link to eventreport.php eventReportLink not reportLink
- Log interpolated queries, they are just much easier to debug
- Don't allow event name to be null, we don't allow events without names
- Update psalm baseline now that we use interpolateQuery for debugging logging
- Event->name is no longer nullable which clears up a lot of type errors
- Set Event->current_round to not be nullable, like the database
- Mark a lot more properties of Event that are not-nullable in the db as not null
- Bring model into line with database and make Player->name not nullable
- Declare in line with db that some properties of Player are not nullable
- Move Entry's constructor to top of file
- Bit overzealous marking things as not nullable
- Remove "ignore" functionality
- River-style SQL over more spaced out version
- Bring Entry and EntryDto in line with nullability of props in database
- Remove PHPDoc tags we aren't supporting
- Bring models and database yet further in sync, removing lots of nullable props
- Bring some properties of Matchup in line with database
- Update copy to more correctly describe what's going to happen
- Use our superglobal helper to get typesafe values and fix static checker errors
- Declare war on pointless use of strcmp
- Eradicate strcmp from the codebase
- Get timezone in the approved way
- Swtich to river-style SQL to save space/for clarity
- Give main the more correct return type of never - we output and then exit
- Redirect to player.php rather than show a blank screen on report.php
- Copy update for error messages about sideboard
- River-style SQL formatting
- Don't use strings-as-funcs anywhere, prefer fn and real lambdas
- Get rid of unused column on players
- Site name is no longer configurable
- Don't error if there are two or more events with the most recent date
- Don't center player name on ratings table, it looks wonky
- Don't need to check for null event name now that it's not nullable
- Don't show 'Round 0' for unstarted events, show 'Not Yet Started'
- Always show headings in silver not link color in Current Events section
- Buttons are now larger, this looks silly for the not allowed icon
- Whoops we clobbered the player search form on profile.php at some point
- Don't squish text on buttons of formatcp
- Bump semver to celebrate our first real visual changes
- Update psalm baseline now we are using the unused PlayerSearchForm
- Remove unused import
- Suppress unused method warning from psalm
- Move test to the correct namespace
- Start to move the last of the "global" funcs out of lib.php
- Upgrade to PHP 8.2, switch to using "Safe" versions of built in funcs
- Convince psalm that interpolateQuery will return a string not an array
- Remove FileNotFoundException
- Simplify setting of prereg default
- Move yet more stuff out of lib.php
- Detect restricted sideboard cards (a little) more sanely
- Find decks that match all criteria more simply
- Remove unused func
- Remove unused func
- Remove unused func
- Remove two initializations that are always overwritten
- Remove all concept of "Round Robin" structure, there's none in the db
- Remove unused vars
- Don't call set_time_limit until after we've autoloaded in lib
- Bring phpstan baseline up to date with latest fixes
- Fix an ancient snafu found by psalm
- Move git_hash to inline and version_tagline to Page (only user)
- Remove dead code
- Remove pointless variable assignment
- Remove dead code, fix return types
- Kill some unused vars
- Kill a bunch of unused code
- Remove unused func
- Convert to void funcs where we don't use the return value
- Remove unused vars
- Don't use string names of funcs as lambdas now that fn exists
- Reorganize code to be nearer to usage and less global
- Get more specific about types in pairing weights
- Don't check for null if it can't be null, live up to type promises
- Migrate game/platform constants to where they are used
- Type fixes
- Type fixes
- Don't pass unused var
- Update psalm baseline after fixing a bunch of stuff
- Fix visibility
- Lint
- Update all libraries trying to fix a psalm issue (didn't help)
- Set threads=1 for psalm because of Fatal error since PHP 8.3.9+ vimeo/psalm#11067
- Don't counterfeit property with private fun name - confuses mustache
- Clearer display when an event is upcoming versus in progress, better links
- Complete the update to PHP 8.2 in composer, docker, github
- Github CI/CD doesn't allow set_time_limit so cope with that
…assword Before we were saying they didn't match which is not quite right.
This is more precise as season is always an int or not present.
You can still forget to call parent constructor but at least it's consistent now and I found a couple spots where we were not providing a title.
We can do better here but return it to working order for now.
We lose the highlighting of the fault search term but that doesn't seem super important.
Getting rid of them throughout the app is going to require changing how table.form works, though, I think.
It's more complicated than I thought - we also spider over lists that DO have integer keys.
reportLink is when you report a match result.
It was never really nullable truly but the code is able to express it now in a way that phpstan can understand.
It would be nice to make this a backed enum and use it instead of ints everywhere (even disallowing ints) but for now we get it out of lib.php.
If you actually find this slow you could remove it because it's just a visual bug really.
I'll merge this to dev and switch on prod if things go smoothly for the next short while. This is live on prod on the branch for now. |
Only add it if they filled out the dropdowns for a new match, otherwise they might be deleting matches or reporting results, etc. and not trying to add a new match. This would've been caught by foreign keys only there's a player with the name empty string gdi. Might have to re-org the db so an FK that stops you having a match in a tournament you're not in is easier to declare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.