-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdEmbree] add distant light support (hdEmbree-UsdLux-PR14) #3191
Open
pmolodo
wants to merge
12
commits into
PixarAnimationStudios:dev
Choose a base branch
from
NVIDIA-Omniverse:pr/hdEmbree-distant-lights
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[hdEmbree] add distant light support (hdEmbree-UsdLux-PR14) #3191
pmolodo
wants to merge
12
commits into
PixarAnimationStudios:dev
from
NVIDIA-Omniverse:pr/hdEmbree-distant-lights
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Jul 31, 2024
pmolodo
force-pushed
the
pr/hdEmbree-distant-lights
branch
from
August 1, 2024 18:46
214b5c8
to
c90bbc4
Compare
Filed as internal issue #USD-9909 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
pmolodo
changed the title
[hdEmbree] add distant light support
[hdEmbree] add distant light support (hdEmbree-UsdLux-PR09)
Aug 7, 2024
pmolodo
force-pushed
the
pr/hdEmbree-distant-lights
branch
from
September 23, 2024 18:11
c90bbc4
to
ab8259e
Compare
pmolodo
force-pushed
the
pr/hdEmbree-distant-lights
branch
from
October 21, 2024 17:06
ab8259e
to
9212698
Compare
pmolodo
changed the title
[hdEmbree] add distant light support (hdEmbree-UsdLux-PR09)
[hdEmbree] add distant light support (hdEmbree-UsdLux-PR14)
Oct 21, 2024
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
pmolodo
force-pushed
the
pr/hdEmbree-distant-lights
branch
2 times, most recently
from
October 23, 2024 17:29
dc1a20b
to
8186d1d
Compare
This modifies the hdEmbree example plugin to do direct lighting so as to provide a reference implementation of the expected behaviour for UsdLux. If no lights are present in the stage, the old ambient occlusion path will be used.
A few small utility functions from pbrt-v4
pmolodo
force-pushed
the
pr/hdEmbree-distant-lights
branch
from
October 23, 2024 18:20
8186d1d
to
d2840eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Adds support for distant UsdLux lights to the hdEmbree renderer
Related PRs:
This PR is part of a chain of PRs that provide a reference implementation of UsdLux as part of hdEmbree.
Due to a github limitation, this PR must include all previous PRs in the chain. To see JUST the changes in this PR vs the previous in the chain, click this link
⛓️ All PRs in this chain:
📃 Documentation PR:
This chain of PRs (implementing UsdLux support in hdEmbree), was made separate from the PR documenting expected UsdLux behavior:
✳️ All UsdLux update related PRs:
To see ALL UsdLux update related PRs (documentation AND reference implementation) in one place, see:
⌛ Original PR:
These PRs are an update of this original PR:
But... why??
Why make these PRs in the first place?
The current specifications of the various UsdLux prims + attributes are imprecise or vague in many places, and as a result, actual implementations of them by various renderers have diverged, sometimes quite significantly. For instance, here is Intel's 4004 Moore Lane scene, with the same UsdLux lights defined, in 3 different renderers:
Karma:
Arnold:
Omniverse RTX:
For a full descpription of the problem, see here:
Why so many PRs?
This was my attempt to break up a rather large change into smaller, more easily reviewable changes, that can be merged in incrementally, to help ease the burden for code reviewers.
If you find this confusing, and would rather just one big PR (ie, just this one), or have them organized in some other way, please let me know!
Why are the documentation changes in their own PR?
In some ways, the documentation changes are the heart of this effort - we wish to specify more exactly what the various UsdLux prims and attributes represent. However, building consensus on this may take time - so we expect some dialogue on the exact language or formulas.
Because that may take time, the hdEmbree reference implementation changes are separate, and broken up, so we can hopefully start integrating portions of them even before final consensus has been reached on the final form of the specification.
Why are the documentation changes not broken up into smaller pieces, like the hdEmbree reference implementation changes?
Because I wasn't sure if that would be desirable or not! If people think that would be helpful, I can do so - perhaps breaking out by schema or individual attribute?