feat: add build loading awareness in the terminal(#1117) #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import loading awareness animation for build process - Start loading animation when build and rebuild starts - Stop loading animation when build succeeds or fails
louisgv
reviewed
Nov 1, 2024
There was a problem hiding this comment.
The current convention is a bit extreme on not using "let" :-?
Can we make a const state like this instead:
const state = {
loadingInterval: null as NodeJS.Timeout | null,
isLoading: false,
dotCount: 0
}
louisgv
reviewed
Nov 1, 2024
| if (isLoading) return | ||
| isLoading = true | ||
| let dots = 0 | ||
| const baseString = "🔄 Building" |
There was a problem hiding this comment.
let's pull this outside, since it's a literal string
Comment on lines
+87
to
+88
| if (event.type === "buildFailure") { | ||
| stopLoading() |
| let isLoading = false | ||
|
|
||
| export const startLoading = () => { | ||
| if (isLoading) return |
| } | ||
|
|
||
| export const stopLoading = () => { | ||
| if (!isLoading) return |
- Move state management to a single state object - Extract LOADING_TEXT to constants - Add consistent bracket style
|
@louisgv Thanks for the review! I've addressed all the suggestions:
Please let me know if there's anything else that needs to be adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR enhances the build process feedback by implementing a loading animation in the terminal. It addresses the issue of unclear build status during development, especially for longer builds or multiple hot reloads.
Specifically, this PR:
This change aims to solve the problem described in issue #1117, where it was difficult to determine if a build was in progress or completed, especially after multiple hot reloads.
I'm open to any feedback or suggestions for improvement. If you have any questions or if there's anything you'd like me to modify, please leave a comment.
Code of Conduct
Contacts