Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNatural #791

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

PNatural #791

wants to merge 5 commits into from

Conversation

kozross
Copy link
Contributor

@kozross kozross commented Dec 18, 2024

Adds PNatural, as well as some support in type class operations. I haven't modified any existing functions to use it, although in many cases (such as indexing), we definitely should. Will save that for another PR.

@kozross kozross requested a review from t4ccer December 18, 2024 21:53
Copy link
Collaborator

@t4ccer t4ccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally correct, but would be good to cut down on using punsafeCoerce in internal code, found a few places but there's probably a bit more

Plutarch/Internal/Numeric.hs Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
@kozross kozross requested a review from t4ccer December 19, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants