Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extended block state performance #45

Merged
merged 17 commits into from
Jul 19, 2024
Merged

extended block state performance #45

merged 17 commits into from
Jul 19, 2024

Conversation

MicrocontrollersDev
Copy link

@MicrocontrollersDev MicrocontrollersDev commented Jul 14, 2024 •
edited
Loading

Description

this pr has been split into several PRs. see #57 #58 and #59

WorldMixin_FixEarlyLightInitialization: MinecraftForge/MinecraftForge#4729
InvWrapperMixin_ImproveInsertion & SidedInvWrapperMixin_ImproveInsertion: MinecraftForge/MinecraftForge#4468 and MinecraftForge/MinecraftForge#3622
ExtendedBlockStateMixin
ExtendedStateImplementation & ExtendedBlockStateMixin_FasterCreateState: https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/main/java/net/minecraftforge/common/property/ExtendedBlockState.java

Related Issue(s)

Fixes #

How to test

Release Notes

Boost performance by improving insertion into Forge's inventory wrappers
Boost performance of Forge's create block state implementation
Fix several Forge memory leaks
Fix vanilla light initializing too early

Documentation

Wyvest
Wyvest requested changes Jul 14, 2024
View reviewed changes
Copy link
Member

@Wyvest Wyvest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

havent tested yet but yeah

src/main/java/club/sk1er/patcher/mixins/performance/WorldMixin_FixEarlyLightInitialization.java Outdated Show resolved Hide resolved
src/main/java/club/sk1er/patcher/mixins/performance/forge/OBJModelMixin_UnclosedStreams.java Outdated Show resolved Hide resolved
@MicrocontrollersDev MicrocontrollersDev marked this pull request as ready for review July 14, 2024 22:46
@MicrocontrollersDev MicrocontrollersDev changed the title add a few forge backports extended block state performance Jul 18, 2024
@Wyvest Wyvest merged commit 21a8237 into Polyfrost:main Jul 19, 2024
1 check passed
@MicrocontrollersDev MicrocontrollersDev deleted the forge-backports branch July 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyvest Wyvest Wyvest requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicrocontrollersDev @Wyvest