Move more playback code to rust #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
snylonue
commented
Feb 28, 2024
•
snylonue
commented
- play while downloading
- validate cache
- better seeking implementation
- quality selection
- fix playback issues
- possible glitches if downloading is slow
- support preloading
- migrate cache
- clean up dart code
Basically a wrapper of anni-playback with additional functionality.
|
Test is needed. |
|
Is this PR ready for review? |
IMO the playback part is finished, but may have some bugs. |
otherwise player state is not correct when start playing, resulting in wrong track being played and duplicate disposal of tracks
It's ready for review. |
Yesterday17
reviewed
Jul 19, 2024
Yesterday17
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.