Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support css in disguise as JS in plugin-import-css #747

Merged
merged 4 commits into from
Oct 20, 2021
Merged

support css in disguise as JS in plugin-import-css #747

merged 4 commits into from
Oct 20, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 4, 2021 •
edited
Loading

Related Issue

resolves #700 in support of ProjectEvergreen/greenwood-getting-started#42

Summary of Changes

  1. Add support for CSS in disguise as JS, e.g. extension-less CSS, in plugin-import-css (e.g. styles.css.js)

TODO

  1. Add test cases / clean up console logging
  2. README update for the package?

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins labels Oct 4, 2021
@thescientist13 thescientist13 self-assigned this Oct 4, 2021
@thescientist13 thescientist13 added feature New feature or request and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Oct 16, 2021
@thescientist13 thescientist13 force-pushed the feature/issue-700-extensionless-css-import branch from 26d390d to a95a7cb Compare October 16, 2021 18:29
@thescientist13 thescientist13 marked this pull request as ready for review October 16, 2021 18:40
@thescientist13 thescientist13 added the documentation Greenwood specific docs label Oct 16, 2021
@thescientist13 thescientist13 merged commit 7ecafe0 into master Oct 20, 2021
@thescientist13 thescientist13 deleted the feature/issue-700-extensionless-css-import branch October 20, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for extension less JavaScript / CSS files (JS files "in disguise")
1 participant
@thescientist13