-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/issue 820 deeply relative ESM paths in node modules not working #832
Merged
thescientist13
merged 11 commits into
master
from
bug/issue-820-deeply-relative-ESM-paths-node-modules-break
Mar 5, 2022
Merged
Bug/issue 820 deeply relative ESM paths in node modules not working #832
thescientist13
merged 11 commits into
master
from
bug/issue-820-deeply-relative-ESM-paths-node-modules-break
Mar 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thescientist13
changed the title
Bug/issue 820 deeply relative esm paths node modules break
Bug/issue 820 deeply relative esm paths in node modules not working
Dec 28, 2021
thescientist13
changed the title
Bug/issue 820 deeply relative esm paths in node modules not working
Bug/issue 820 deeply relative ESM paths in node modules not working
Dec 28, 2021
thescientist13
force-pushed
the
bug/issue-820-deeply-relative-ESM-paths-node-modules-break
branch
from
February 26, 2022 18:09
2ea7a95
to
e94dcd0
Compare
5 tasks
thescientist13
force-pushed
the
bug/issue-820-deeply-relative-ESM-paths-node-modules-break
branch
from
March 5, 2022 15:55
0cf1fe7
to
459235d
Compare
thescientist13
deleted the
bug/issue-820-deeply-relative-ESM-paths-node-modules-break
branch
March 5, 2022 16:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #820
Summary of Changes
.replace('./', '')
with custom functionality to better handle./
vs../
using @stencil/core for validationwalkModule
on packages that already provide anexports
mapTODO
../
paths\
) to ESM style (/
)some sort of race condition it seems. Looks like the right path from the export map on Windows is being overwritten (?) later on by further calls to🔬 👀updateImportMap
from walking the imports of a related @babel/runtime file? Was able to reproduce the same error on macOS by removing this one-off pre-check, so seems like the issue is somewhere in thereimport.meta.resolve
to support import maps generation and accurate node_modules resolution when building #684import
from a directory #907