fix: separate html-proofer gem from Gemfile #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify config changes: - jekyll build -> bundle exec jekyll build - update node version to 20.x (from 10.x)
This reverts commit 3f0d091.
|
A major fix here was to pin Ruby to 3.3.3, as a recommendation from https://github.com/ruby/bigdecimal/issues/297#issuecomment-2331533389 The HTMLProofer fixes should be resolved once this is rebased into #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo has two separate services performing CI checks: github actions for html-proofer (validates all links on site are accurate), and netlify (preview of website)
Netlify checks are (partly) failing due to issues with html-proofer gem. This gem is only needed for the github actions CI, so this PR moves that requirement inline to the workflow file, and removes it from the Gemfile. In theory this isolates the dependencies and will result in more successful checks.
May require more debugging, pending netlify results.