Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle pycon website to use 2019 branding #654

Merged
merged 15 commits into from
Sep 14, 2018
Merged

Restyle pycon website to use 2019 branding #654

merged 15 commits into from
Sep 14, 2018

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Sep 12, 2018

Known issues:

  1. Logo not showing on FF

  2. Empty h1 is pushing down content Temporary fix pushed. See Do not render page_title if it is empty #655 for a better fix

  3. password reset page

  4. Check page where user resets password @ewdurbin - how can I access this in dev?

!!! NOTE: we need to get permission from Mike Pirnat for use of the photo on the homepage !!!

@ewdurbin
Copy link
Member

@nlhkabu I added the password reset template from pinax-theme-bootstrap to pycon/templates/account/password_reset.html for customization.

@ewdurbin
Copy link
Member

My feedback:

  • Overall it looks fantastic
  • The yellow background for forms is a bit jarring, is there anything we could do to cool it off?
  • Navigation components are well spaced for the dev fixtures but we will end up with more, see us.pycon.org/2018 probably better to tighten them up for now and let them fill out the width as we add pages.
  • At full width in safari I'm getting a small line between the header and nav

screen shot 2018-09-13 at 8 07 17 am

@ewdurbin ewdurbin changed the title WIP: Restyle pycon website to use 2018 branding WIP: Restyle pycon website to use 2019 branding Sep 13, 2018
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Sep 13, 2018

thanks for the feedback @ewdurbin

  • menu item spacing reduced
  • lighter version of the yellow (unless you want another color altogether?)

screenshot from 2018-09-13 20-17-41

I can't seem to reproduce the issue you are seeing on Safari - can you tell me what OS and Safari version you're using?

@ewdurbin
Copy link
Member

Reproduction for that line is:

MacOS High Sierra 10.13.6
Safari 11.1.2

Widen screen above max width.

@ewdurbin
Copy link
Member

Really love the improved form background!

@nlhkabu nlhkabu force-pushed the restyle branch 2 times, most recently from 8e36b9b to d8e60eb Compare September 13, 2018 20:01
@ewdurbin
Copy link
Member

☝️ that worked.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Sep 13, 2018

All ready on my side @ewdurbin 💃

As discussed, we'll probably need to look at some other pages later e.g:

  • Proposal submission
  • Schedule
  • Job board

But I think this is good enough for what you need right now :)

I've tested across a variety of browsers, including ie11, which is the one that tends to cause issues, and I can see no defects.

@nlhkabu nlhkabu changed the title WIP: Restyle pycon website to use 2019 branding Restyle pycon website to use 2019 branding Sep 13, 2018
@ewdurbin
Copy link
Member

Thanks for your work @nlhkabu!

@ewdurbin ewdurbin merged commit 50e930a into develop Sep 14, 2018
@ewdurbin ewdurbin deleted the restyle branch September 24, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants