-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TYNDP projects in data/transmission_projects/manual #1305
base: master
Are you sure you want to change the base?
Conversation
Validator ReportI am the Validator. Download all artifacts here. ❗ Run failed!Download 'logs' artifact to see more details.
Model Metrics Comparing |
@lkstrp this validator is soo cool! |
Hi @lindnemi , thanks a lot for the manual labor. Regarding your question:
Yes, I would remove them, because the catching of duplicates should work, but if we know the link is already in OSM, then we can also remove it to make sure it is not added twice. Did you check if the lines were added correctly to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, as @p-glaum says.
|
Hi @lindnemi, the PR looks good and drops the intended lines. However, I honestly do not understand why for you the duplicated links were still added in the master. I just ran the current master again and there the duplicated NEP links are not added. Here are the logs from my last run:
|
Just ran it again from pypsa-ariadne repo and the lines are still not dropped. I also noticed that the
|
Snakemake not triggering the recomputation of transmission_projects when the csvs change might be related to snakemake/snakemake#2011 |
What's the status here? |
Closes # (if applicable).
Changes proposed in this Pull Request
IFA 2 and Italy-France interconnector are already in operation. Should they be removed as well?
Build_years were added for all entries
Capacity was slightly decreased from 1400 to 1250 for two projects
Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.