Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep existing conventional generation in sector network #1366

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

martacki
Copy link
Member

@martacki martacki commented Oct 16, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

The sector coupled network currently removes existing conventional generators. This PR adds them back (in the traditional sectoral setup with EU Generators + Links)

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
weighted_prices.csv ⚠️Changed 0.514 0.50
price_statistics.csv ⚠️Changed 0.001 0.21
metrics.csv ⚠️Changed 0.000 0.06
nodal_cfs.csv ⚠️ NaN mismatch
nodal_supply_energy.csv ⚠️ NaN mismatch
nodal_capacities.csv ⚠️ NaN mismatch
prices.csv ⚠️ NaN mismatch
supply.csv ⚠️ NaN mismatch
nodal_costs.csv ⚠️ NaN mismatch
market_values.csv ⚠️ NaN mismatch
capacities.csv ⚠️ NaN mismatch
curtailment.csv ⚠️ NaN mismatch
costs.csv ⚠️ NaN mismatch
cfs.csv ⚠️ NaN mismatch
supply_energy.csv ⚠️ NaN mismatch
energy.csv ⚠️ NaN mismatch

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing keep_conventionals_in_sector (37c6093) with master (52b8179).
Branch is 8 commits ahead and 0 commits behind.
Last updated on 2024-11-05 11:03:42 CET.

@martacki
Copy link
Member Author

martacki commented Oct 16, 2024

Except for typos (my specialty), there seems to be only the same bug as in master, which is why Windows OS is failing (nut sure about why).

Remaining discussion points could be:

  • I designed the same setup for nuclear as for fossil generation (Generator uranium connected with a nuclear link). I think that makes more sense, currently it simply remained a "nuclear generator", but this was a bit confusing
  • Currently, if existing capacities are kept and the carrier is expandable, only the existing locations can be expanded. The same carrier can not be expanded at a different site, if that site has no existing capacity. Could be potentially fixed, but wasn't needed in our case

Otherwise, seems to work.
Nuclear / coal generation in power only model:
image

Nuclear/coal generation at sectoral model:
image
image
image

Sectoral model dispatch (in links_t.p1) (Co2L0.5 for whole EU, 121H, 59 clusters)
nuclear
image
coal
image

default config settings don't change the current default output (except that nuclear is not kept anymore in the generators)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant