-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update shared_resources "base" to not retrigger renewable profiles #1403
base: master
Are you sure you want to change the base?
Conversation
"determine_availability_matrix_", | ||
"solar_thermal", | ||
) | ||
if any(prefix in fn for prefix in shared_files) or is_shared: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the or is_shared
necessary? Looks like it could be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is necessary here.
Because for the first is_shared
, in the previous behaviour, you had neither a relevant_wildcard nor a shared_rule to make it shared. However, with the new structure, this would always be False for the profiles, meaning that they are never shared in the end.
This is why I added shared_files
, and if any of those is in the file name, then the resource is always shared.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to test this. Do you have a configfile/s to run to validate the intended behaviour?
I just had two different scenarios "A", "B" like
with the scenario.yaml
|
Makes that with
shared_resources=base
, the previous behavior is recovered and every rule starting fromadd_electricity
is not shared anymore, but the renewable profiles are shared.Changes proposed in this Pull Request
Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.