Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics post processing for csv creation and plotting #921

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

p-glaum
Copy link
Contributor

@p-glaum p-glaum commented Feb 9, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • add try except similar to make_summary to allow plotting of comparison even though not all runs are present yet

  • think about making a dictionary in config.yaml of what to plot, i.e. "total_cost" for carrier="all" and "energy_balance" for all individual carriers

  • I tested my contribution locally and it seems to work fine.

  • Code and workflow changes are sufficiently documented.

  • Changed dependencies are added to envs/environment.yaml.

  • Changes in configuration options are added in all of config.default.yaml.

  • Changes in configuration options are also documented in doc/configtables/*.csv.

  • A release note doc/release_notes.rst is added.

@FabianHofmann
Copy link
Contributor

just a mini comment on the naming, perhaps write_statistics is better than make_statistics_csv?

@p-glaum
Copy link
Contributor Author

p-glaum commented Feb 9, 2024

just a mini comment on the naming, perhaps write_statistics is better than make_statistics_csv?

Yes, you are right. I will change it :)

@p-glaum p-glaum marked this pull request as draft February 12, 2024 09:40
@p-glaum p-glaum marked this pull request as ready for review February 12, 2024 12:54
@p-glaum p-glaum requested a review from fneum February 12, 2024 15:19
@p-glaum p-glaum marked this pull request as draft April 25, 2024 18:35
@p-glaum p-glaum removed the request for review from fneum April 26, 2024 07:50
@p-glaum p-glaum marked this pull request as ready for review July 8, 2024 14:04
@p-glaum p-glaum added the DNMY Do not merge yet label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNMY Do not merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants