Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check for docs if the user wants to run the task. #1044

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

gperetin
Copy link
Contributor

@gperetin gperetin commented Jul 3, 2024

We want to fetch external docs only if the user wants to execute the task (not for skipped tasks).

This is not ideal implementation, as it's not intuitive in the Developer agent when we check for docs, but I think it's better than the alternative.

Initially, I wanted to move the external docs check into Developer agent, sort of like what get_relevant_files does, but gave up, as that would clobber the Developer quite a lot - external docs is much more complex, does 2 LLM requests and 2 API requests.

The complexity arises from the fact how control flow is done between agents, which is through AgentResponse, and a bunch of checks in Orchestrator and various agents. I'm open to suggestions on how to make this better.

@LeonOstrez LeonOstrez merged commit bd0afbe into main Jul 4, 2024
6 checks passed
@LeonOstrez LeonOstrez deleted the move-docs-check branch July 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants