Only check for docs if the user wants to run the task. #1044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to fetch external docs only if the user wants to execute the task (not for skipped tasks).
This is not ideal implementation, as it's not intuitive in the
Developer
agent when we check for docs, but I think it's better than the alternative.Initially, I wanted to move the external docs check into
Developer
agent, sort of like whatget_relevant_files
does, but gave up, as that would clobber theDeveloper
quite a lot - external docs is much more complex, does 2 LLM requests and 2 API requests.The complexity arises from the fact how control flow is done between agents, which is through
AgentResponse
, and a bunch of checks inOrchestrator
and various agents. I'm open to suggestions on how to make this better.