Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant parametrization from wasserstein_1d tests #517

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

kachayev
Copy link
Collaborator

Types of changes

Remove redundant pytest.mark.parametrize in favor of nx fixture.

Motivation and context / Related issue

Unify with the rest of the tests.

How has this been tested (if it applies)

n/a

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@kachayev
Copy link
Collaborator Author

Is there a way to re-run CI jobs without pushing new commit? 🤔 It seems like a timeout triggered on this change is somewhat random, not sure how it could be caused by the changes made.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #517 (824d7a2) into master (5331480) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   96.05%   96.06%   +0.01%     
==========================================
  Files          65       65              
  Lines       13732    13725       -7     
==========================================
- Hits        13190    13185       -5     
+ Misses        542      540       -2     

@rflamary rflamary merged commit 064898d into PythonOT:master Sep 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants