Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update doc for unbalanced sinkhorn #700

Merged
merged 2 commits into from
Nov 27, 2024
Merged

[DOC] Update doc for unbalanced sinkhorn #700

merged 2 commits into from
Nov 27, 2024

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Nov 27, 2024

Types of changes

Issue #691 has highlighted a change in default behavior for the regularization of unbalanced OT. This was not properly stated in the release note but we added here a warning block in the doc of the functions to make teh change in behavior more clear.

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (05341bb) to head (6926d6a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files          98       98           
  Lines       19955    19955           
=======================================
  Hits        19370    19370           
  Misses        585      585           

@rflamary rflamary merged commit 7019709 into master Nov 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant