Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for spillover control overmatch #45

Closed
wants to merge 1 commit into from

Conversation

jacobpwagner
Copy link
Member

This just adds a more helpful error message for the case in #44, where the regex matches multiple files. The regex check does not include ^ or $ anchors (possibly appropriately), so in the relatively common case of a channel being a substring of another channel (e.g. "V610" and "UV610"), the match will be ambiguous and the return from grep will be a jagged list instead of a vector.

@jacobpwagner
Copy link
Member Author

Also, one test fails, but it was failing before my changes.

@mikejiang mikejiang deleted the branch RGLab:master July 10, 2023 21:20
@mikejiang mikejiang closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants