Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDAP Search - Basic Fixes #1611

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

MiguelAHM
Copy link
Contributor

@MiguelAHM MiguelAHM commented Dec 17, 2024

to fix:

  • Handle in IPs should match the handle in the RDAP output
  • Do exact match in IPs and Autnums. Tom pointed that it seems that we are adding a trailing * at the end. We allow * so lets leave to the user if they want to add *
  • We should be returning an empty value in search if non value is found. Do not return a 404 (this is applied to all RDAP search, including entities...domains...etc)

@eshryane
Copy link
Member

FYI I tested wildcard search with a term that will match a lot of objects (i.e. every inet6num primary key) and the response was returned quickly and limited correctly to 100 results.

$ curl -o file -v "http://localhost:1080/rdap/ips?handle=2001*"
$ fgrep '"handle"' file | grep "2001" | wc -l
100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants