Skip to content

Commit

Permalink
Fix CMake Failure Within Libraries/ (#129)
Browse files Browse the repository at this point in the history
* Fix CMake Failure Within Libraries/

Project languages is not set before "find_package" is called.
This leads to a configuration failure when running `cmake`
within the `Libraries/` folder.

* Update README.md
* Update project languages in additional CMakelists

Signed-off-by: David Galiffi <[email protected]>
  • Loading branch information
dgaliffiAMD authored Jun 21, 2024
1 parent 8cca20d commit 91943eb
Show file tree
Hide file tree
Showing 13 changed files with 20 additions and 16 deletions.
4 changes: 4 additions & 0 deletions HIP-Basic/texture_management/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,7 @@ This example demonstrates how a kernel may use texture memory through the textur
- `hipStreamDefault`
- `hipTextureDesc`
- `hipTextureObject_t`

## Limitations

This example is not supported on CDNA3 architecture (MI300) and above.
2 changes: 1 addition & 1 deletion Libraries/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(Libraries LANGUAGES NONE)
project(Libraries LANGUAGES CXX)

# CMake configuration files for CUDA versions of HIP libraries are not yet
# included under the HIP SDK for Windows.
Expand Down
2 changes: 1 addition & 1 deletion Libraries/hipBLAS/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(hipBLAS_examples LANGUAGES NONE)
project(hipBLAS_examples LANGUAGES CXX)

if(WIN32)
set(ROCM_ROOT
Expand Down
2 changes: 1 addition & 1 deletion Libraries/hipSOLVER/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(hipSOLVER_examples LANGUAGES NONE)
project(hipSOLVER_examples LANGUAGES CXX)

if(WIN32)
set(ROCM_ROOT
Expand Down
2 changes: 1 addition & 1 deletion Libraries/rocBLAS/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocBLAS_examples LANGUAGES NONE)
project(rocBLAS_examples LANGUAGES CXX)

if(GPU_RUNTIME STREQUAL "CUDA")
message(STATUS "rocBLAS examples do not support the CUDA runtime")
Expand Down
4 changes: 2 additions & 2 deletions Libraries/rocBLAS/level_1/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# MIT License
#
# Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All rights reserved.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
Expand All @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocBLAS_level_1_examples LANGUAGES NONE)
project(rocBLAS_level_1_examples LANGUAGES CXX)

add_subdirectory(axpy)
add_subdirectory(dot)
Expand Down
4 changes: 2 additions & 2 deletions Libraries/rocBLAS/level_2/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# MIT License
#
# Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All rights reserved.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
Expand All @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocBLAS_level_2_examples LANGUAGES NONE)
project(rocBLAS_level_2_examples LANGUAGES CXX)

add_subdirectory(gemv)
add_subdirectory(her)
4 changes: 2 additions & 2 deletions Libraries/rocBLAS/level_3/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# MIT License
#
# Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All rights reserved.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
Expand All @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocBLAS_level_3_examples LANGUAGES NONE)
project(rocBLAS_level_3_examples LANGUAGES CXX)

add_subdirectory(gemm)
add_subdirectory(gemm_strided_batched)
2 changes: 1 addition & 1 deletion Libraries/rocSOLVER/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocSOLVER_examples LANGUAGES NONE)
project(rocSOLVER_examples LANGUAGES CXX)

if(GPU_RUNTIME STREQUAL "CUDA")
message(STATUS "rocSOLVER examples do not support the CUDA runtime")
Expand Down
2 changes: 1 addition & 1 deletion Libraries/rocSPARSE/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocSPARSE_examples LANGUAGES NONE)
project(rocSPARSE_examples LANGUAGES CXX)

if(GPU_RUNTIME STREQUAL "CUDA")
message(STATUS "rocSPARSE examples do not support the CUDA runtime")
Expand Down
2 changes: 1 addition & 1 deletion Libraries/rocSPARSE/level_2/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocSPARSE_level_2_examples LANGUAGES NONE)
project(rocSPARSE_level_2_examples LANGUAGES CXX)

add_subdirectory(bsrmv)
add_subdirectory(bsrsv)
Expand Down
4 changes: 2 additions & 2 deletions Libraries/rocSPARSE/level_3/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# MIT License
#
# Copyright (c) 2023 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (c) 2023-2024 Advanced Micro Devices, Inc. All rights reserved.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
Expand All @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocSPARSE_level_3_examples LANGUAGES NONE)
project(rocSPARSE_level_3_examples LANGUAGES CXX)

add_subdirectory(bsrmm)
add_subdirectory(bsrsm)
Expand Down
2 changes: 1 addition & 1 deletion Libraries/rocSPARSE/preconditioner/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# SOFTWARE.

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(rocSPARSE_preconditioner_examples LANGUAGES NONE)
project(rocSPARSE_preconditioner_examples LANGUAGES CXX)

add_subdirectory(bsric0)
add_subdirectory(bsrilu0)
Expand Down

0 comments on commit 91943eb

Please sign in to comment.