Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic mods for atmega16u2 #163

Closed
wants to merge 3 commits into from

Conversation

zacharytomlinson
Copy link

make atmega16u2
-e SVD2RUST atmega16u2
error: a value is required for '-i ' but none was supplied

@Rahix
Copy link
Owner

Rahix commented Oct 16, 2024

Hi,

I think the problem is that your ATDF is called atmega16U2 instead of atmega16u2...

@Rahix
Copy link
Owner

Rahix commented Oct 16, 2024

I pushed commit 5a58673 ("make: Fix make continuing when the ATDF source file is missing") to have make error out instead of svd2rust when this happens. But the error message is still not great due to my make magic not being good enough...

@zacharytomlinson
Copy link
Author

Jesus your right.... That's the stupidest mistake I've made in at least the last 12 minutes lol. I changed the filename and now it is building. How would you prefer for me to clean up? Mark the issue complete, close this draft PR and open a new one, or just update this PR?

@Rahix
Copy link
Owner

Rahix commented Oct 16, 2024

Well, the error message could have been way more clear - there's nothing hinting at a file not being found... So don't be too hard on yourself ^^


Usually, it would have been just fine to continue with this PR, and then mark it as ready for review once you are done. But you can also open a new one, don't worry :)

@zacharytomlinson
Copy link
Author

I am going to do a once-over of the patch to make sure the basics are all in there and there are no glaring issues and then I will open a new one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants