WIP: port tests from Midas Protocol #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom-midas-protocol
|
Test currently fails due to a difference in |
zerosnacks
changed the title
|
Temporarily blocked until #18 has been investigated |
In the meantime I will continue to look into a temporary solution as the goal is to bring the codebase first in line 1:1 with what is running in production |
zerosnacks
changed the base branch from
feature/add-fuse-plugin-4626
to
development
zerosnacks
commented
May 18, 2022
.gitignore
Outdated
| @@ -65,6 +65,7 @@ xcuserdata/ | |||
|
|
|||
| # Solidity | |||
| /out/ | |||
| /artifacts/ | |||
There was a problem hiding this comment.
evaluate if this markes sense
…bugging past deployCode blocks
…t does not inline the code correctly
…ytecode so the deployed code in the tests becomes 0x
…ashing' into feature/port-tests-from-midas-protocol
zerosnacks
force-pushed
the
feature/port-tests-from-midas-protocol
branch
from
96a79e5 to
92d82f6
Compare
|
Closing this PR, decided not to port tests 1:1 from Midas but rather take some of their core learnings and implement them separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.