Feat/contract packages #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
reviewed
Jun 16, 2022
zerosnacks
reviewed
Jun 16, 2022
|
Thanks @cryptickoan for the PR Added some minor notes but generally LGTM |
pedrommaiaa
approved these changes
Jun 16, 2022
Short documentation for available scripts
zerosnacks
reviewed
Jun 22, 2022
| "typechain": "^8.1.0", | ||
| "typescript": "^4.7.3" | ||
| }, | ||
| "description": "" |
There was a problem hiding this comment.
Might be nice to add a description for each package
zerosnacks
reviewed
Jun 22, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "fuse-v1", | |||
| "version": "0.1.0", | |||
There was a problem hiding this comment.
I would prefer to leave this 0.1.0 seeing as it is a moving target. Any patches would then be 0.1.1, 0.1.2 etc..
|
Some final minor notes, other than that LGTM, approved 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will enable package publishing of compiled ABIs under the @fuse-v1 npm name scope. Published contracts are typechain based. I think this would fix contract disparity issues between contract code base and sdk
After changes to any contract are compiled with the interfaces script, we can run
npm run prepare:abisand then publish the changes by running./abi/scripts/publish.sh