Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/redesign #419

Open
wants to merge 16 commits into
base: staging
Choose a base branch
from
Open

F/redesign #419

wants to merge 16 commits into from

Conversation

jarbacoa
Copy link
Collaborator

  • /home route with new redesigned homepage
  • /token/:tokenSymbol route Token Detail page (WIP - blocked by designs needed)

New Header in use on new routes
Multiple new hooks for data fetching

@vercel
Copy link

vercel bot commented May 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rari-capital/rari/3wkUcaLXhtzTdDcyvSWa74qDeBo2
✅ Preview: https://rari-git-f-redesign-rari-capital.vercel.app

[Deployment for 3461c08 failed]

@transmissions11
Copy link
Collaborator

Screen Shot 2021-05-24 at 12 58 05 PM

FTX TOKEN has a super long name cuz the creators of the token are idiots. Let's just implement a manual .replace() on the token name here to correct it into FTT

@transmissions11
Copy link
Collaborator

Screen Shot 2021-05-24 at 12 59 19 PM

Screen Shot 2021-05-24 at 12 59 22 PM

Not really a big fan of these box shadows rn. They look kinda cheap cuz they're not diffused enough. I say we should either remove them entirely or play around with diffusing them more.

@coveralls
Copy link

coveralls commented May 24, 2021

Pull Request Test Coverage Report for Build 872588601

  • 22 of 363 (6.06%) changed or added relevant lines in 52 files are covered.
  • 6 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.4%) to 9.677%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/pages/Fuse/FusePoolCreatePage.tsx 0 1 0.0%
src/components/pages/Fuse/FusePoolEditPage.tsx 0 1 0.0%
src/components/pages/Fuse/FusePoolInfoPage.tsx 0 1 0.0%
src/components/pages/Fuse/FusePoolPage.tsx 0 1 0.0%
src/components/pages/Pool2/Pool2Modal/AmountSelect.tsx 0 1 0.0%
src/components/pages/Tranches/TranchesPage.tsx 0 1 0.0%
src/components/shared/Logos.tsx 1 2 50.0%
src/context/PoolContext.tsx 1 2 50.0%
src/utils/bigUtils.ts 0 1 0.0%
src/utils/fetchFusePoolData.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/App.tsx 1 58.06%
src/components/pages/Fuse/FusePoolsPage.tsx 1 0%
src/components/pages/Stats/Totals/StatsTotalSection.tsx 1 0%
src/components/shared/SliderWithLabel.tsx 1 0%
src/components/shared/SwitchCSS.tsx 1 0%
src/hooks/useFusePoolData.ts 1 0%
Totals Coverage Status
Change from base Build 859102421: -0.4%
Covered Lines: 746
Relevant Lines: 5583

💛 - Coveralls

@transmissions11
Copy link
Collaborator

Screen Shot 2021-05-24 at 1 00 34 PM

There are three colors used in this bar. Lets just go with grey for the image, the text and the border

@github-actions
Copy link

Bundled size for the package is listed below:

build/static/media: 679.69 KB
build/static/js: 31.21 MB
build/static/css: 27.34 KB
build/static: 31.91 MB
build: 31.99 MB

@transmissions11
Copy link
Collaborator

Screen Shot 2021-05-24 at 1 01 52 PM

No underline here imo (or make it match the color of the text at least)

@transmissions11
Copy link
Collaborator

Screen Shot 2021-05-24 at 1 02 26 PM

More space between the dots and the text imo

@transmissions11
Copy link
Collaborator

Screen Shot 2021-05-24 at 1 02 50 PM

Add a little more top padding to the pool name imo

@github-actions
Copy link

Bundled size for the package is listed below:

build/static/media: 679.69 KB
build/static/js: 31.21 MB
build/static/css: 27.34 KB
build/static: 31.91 MB
build: 31.99 MB

1 similar comment
@github-actions
Copy link

Bundled size for the package is listed below:

build/static/media: 679.69 KB
build/static/js: 31.21 MB
build/static/css: 27.34 KB
build/static: 31.91 MB
build: 31.99 MB

@github-actions
Copy link

Bundled size for the package is listed below:

build/static/media: 679.69 KB
build/static/js: 31.21 MB
build/static/css: 27.34 KB
build/static: 31.91 MB
build: 31.99 MB

@transmissions11
Copy link
Collaborator

Screen Shot 2021-05-24 at 2 09 49 PM

This icon is still white fyi— should be grey if possible

@jarbacoa jarbacoa requested a review from transmissions11 May 25, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants