Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel initiated slot correction - [ENG 414] #12718

Closed
wants to merge 7 commits into from
Closed

Cancel initiated slot correction - [ENG 414] #12718

wants to merge 7 commits into from

Conversation

varunshankar
Copy link
Contributor

@varunshankar varunshankar commented Aug 8, 2023 •
edited
Loading

Proposed changes:

  • Modified the pattern_correction as it is decided to not get a confirmation for the user to proceed with the correction.
  • Moved the implementation and the flow to docs

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@varunshankar varunshankar requested a review from a team as a code owner August 8, 2023 06:31
@varunshankar varunshankar self-assigned this Aug 8, 2023
@varunshankar varunshankar changed the title Cancel slot correction - [ENG 414] Cancel initiated slot correction - [ENG 414] Aug 8, 2023
amn41
amn41 requested changes Aug 8, 2023
View reviewed changes
rasa/core/policies/flow_policy.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12718--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@varunshankar varunshankar requested a review from tmbo August 14, 2023 07:57
@tmbo tmbo closed this Aug 31, 2023
@varunshankar varunshankar deleted the ENG-414-cancel-slot-correction branch October 27, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amn41 amn41 amn41 requested changes

@twerkmeister twerkmeister Awaiting requested review from twerkmeister

@tmbo tmbo Awaiting requested review from tmbo

Assignees

@varunshankar varunshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunshankar @tmbo @amn41